Added set_curl_options method to allow custom options#407
Merged
mblaney merged 1 commit intosimplepie:masterfrom Mar 12, 2016
Merged
Added set_curl_options method to allow custom options#407mblaney merged 1 commit intosimplepie:masterfrom
mblaney merged 1 commit intosimplepie:masterfrom
Conversation
Member
|
thanks @arraintxo! |
This was referenced Jul 11, 2015
Alkarex
added a commit
to Alkarex/simplepie
that referenced
this pull request
Jul 11, 2015
Added set_curl_options method to allow custom options Conflicts: library/SimplePie.php library/SimplePie/File.php Choose the generic approach of adding any parameter to cURL simplepie#407 Barnetik@51f9f08 instead of the approach focusing only on proxy aspects simplepie#360 simplepie#359 FreshRSS/FreshRSS@9aab83a
This was referenced Jul 11, 2015
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jul 11, 2015
silent Warning cast with PHP 5.3.3 (RHEL-6) simplepie/simplepie#258 Use rss:pubDate over atom:updated when determining the posting date simplepie/simplepie#288 Update Item.php: add support for media thumbnails simplepie/simplepie#340 Remove PHP Notices simplepie/simplepie#353 And removed "FreshRSS" annotations for pull requests submitted upstream Fixed a typo in Date.php (wrong number for September) simplepie/simplepie#374 Remove duplicate case simplepie/simplepie#406 Added set_curl_options method to allow custom options simplepie/simplepie#407 Improved error message simplepie/simplepie#412
This was referenced Jul 11, 2015
Contributor
There was a problem hiding this comment.
Contributor
|
Hello @arraintxo, What do you think? |
|
+1 this would be a useful feature. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were having troubles with self-signed https hosts and have seen more people with the same issue, so we modified SimplePie to simply allow custom curl_options to be passed as configuration params.
Usage: