Use rss:pubDate over atom:updated when determining the posting date#288
Merged
mblaney merged 2 commits intosimplepie:masterfrom Mar 13, 2016
icewind1991:master
Merged
Use rss:pubDate over atom:updated when determining the posting date#288mblaney merged 2 commits intosimplepie:masterfrom icewind1991:master
mblaney merged 2 commits intosimplepie:masterfrom
icewind1991:master
Conversation
this fixes an issue where feeds that mix rss and atom tags (i.e. youtube channel upload feeds) get an incorrect posting data if the updated time changes
library/SimplePie/Item.php
Outdated
Contributor
There was a problem hiding this comment.
This and the following one should also be preferred to the element
Contributor
|
Thanks for fixing it so I dont have to :) |
Contributor
Author
|
@Raydiation dc:date is now also used over atom:updated |
Contributor
|
hm, is it correct that updated has a higher priority than created and issued? |
Contributor
|
When is this going to be merged? We want to release the beta this weekend. I hope we can use this directly and dont have to ship a custom version of the lib |
Contributor
Contributor
|
@rmccue any update on this? |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jul 11, 2015
silent Warning cast with PHP 5.3.3 (RHEL-6) simplepie/simplepie#258 Use rss:pubDate over atom:updated when determining the posting date simplepie/simplepie#288 Update Item.php: add support for media thumbnails simplepie/simplepie#340 Remove PHP Notices simplepie/simplepie#353 And removed "FreshRSS" annotations for pull requests submitted upstream Fixed a typo in Date.php (wrong number for September) simplepie/simplepie#374 Remove duplicate case simplepie/simplepie#406 Added set_curl_options method to allow custom options simplepie/simplepie#407 Improved error message simplepie/simplepie#412
mblaney
added a commit
that referenced
this pull request
Mar 13, 2016
Use rss:pubDate over atom:updated when determining the posting date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes an issue where feeds that mix rss and atom tags (i.e. youtube channel upload feeds) get an incorrect posting data if the updated time changes.
It might also be useful to place the dc:date tags higher in the order.
An example feed with this issue is http://gdata.youtube.com/feeds/base/users/OfficialNerdCubed/uploads?alt=rss