asgi: check raw_path is not None#719
Merged
simonw merged 1 commit intosimonw:masterfrom May 4, 2020
cldellow:raw-path-none-check
Merged
asgi: check raw_path is not None#719simonw merged 1 commit intosimonw:masterfrom cldellow:raw-path-none-check
simonw merged 1 commit intosimonw:masterfrom
cldellow:raw-path-none-check
Conversation
The ASGI spec (https://asgi.readthedocs.io/en/latest/specs/www.html#http) seems to imply that `None` is a valid value, so we need to check the value itself, not just whether the key is present. In particular, the [mangum](https://github.com/erm/mangum) adapter passes `None` for this key.
Owner
|
Thanks, this is a smart fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ASGI spec
(https://asgi.readthedocs.io/en/latest/specs/www.html#http) seems to imply that
Noneis a valid value, so we need to check the value itself, not just whether the key is present.In particular, the mangum adapter passes
Nonefor this key's value. This change permits mangum to be used to front datasette in Amazon API Gateway + AWS Lambda deployments.