Test against multiple SQLite versions#2352
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2352 +/- ##
==========================================
- Coverage 92.63% 92.63% -0.01%
==========================================
Files 41 41
Lines 6399 6395 -4
==========================================
- Hits 5928 5924 -4
Misses 471 471 ☔ View full report in Codecov by Sentry. |
|
Looks like that test failure is caused by: |
|
That test is still failing because the whole point of that test is to confirm that the clever trick I came up with (and that gets skipped on SQLite 3.46.0) correctly avoids the Lines 604 to 619 in b39b01a |
|
Let's drop macOS for the moment, and just go with Linux. |
|
Got this intermittent failure: https://github.com/simonw/datasette/actions/runs/9494472159/job/26164885108 Really frustrating, I don't think it's anything to do with SQLite versions, I think it's a flaky test. |
|
Let's comment out that test so it doesn't block us on merging this PR, then fix that test in this issue: |
.github/workflows/test-support.yml
Outdated
| # And the test that exceeds a localhost HTTPS server | ||
| tests/test_datasette_https_server.sh |
There was a problem hiding this comment.
We could drop this, it's covered elsewhere
| @@ -0,0 +1,53 @@ | |||
| name: Test | |||
|
Flaky test failed again in a different way: https://github.com/asg017/datasette/actions/runs/9503497141/job/26194049093 |
|
Split out another flaky test issue: |

📚 Documentation preview 📚: https://datasette--2352.org.readthedocs.build/en/2352/