Options:

Better message
If they are signed in as root already, redirect to homepage

I like option 2. Maybe we still show a message if they are NOT signed in as root.

Relevant code:

Lines 73 to 89 in feccfa2

    
           class AuthTokenView(BaseView): 
        
               name = "auth_token" 
        
               has_json_alternate = False 
        
               async def get(self, request): 
        
                   token = request.args.get("token") or "" 
        
                   if not self.ds._root_token: 
        
                       raise Forbidden("Root token has already been used") 
        
                   if secrets.compare_digest(token, self.ds._root_token): 
        
                       self.ds._root_token = None 
        
                       response = Response.redirect(self.ds.urls.instance()) 
        
                       root_actor = {"id": "root"} 
        
                       response.set_cookie("ds_actor", self.ds.sign({"a": root_actor}, "actor")) 
        
                       await self.ds.track_event(LoginEvent(actor=root_actor)) 
        
                       return response 
        
                   else: 
        
                       raise Forbidden("Invalid token")

	class AuthTokenView(BaseView):
	name = "auth_token"
	has_json_alternate = False

	async def get(self, request):
	token = request.args.get("token") or ""
	if not self.ds._root_token:
	raise Forbidden("Root token has already been used")
	if secrets.compare_digest(token, self.ds._root_token):
	self.ds._root_token = None
	response = Response.redirect(self.ds.urls.instance())
	root_actor = {"id": "root"}
	response.set_cookie("ds_actor", self.ds.sign({"a": root_actor}, "actor"))
	await self.ds.track_event(LoginEvent(actor=root_actor))
	return response
	else:
	raise Forbidden("Invalid token")

Uh oh!

Clicking --root link twice is confusing #2375

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions