ci: fix offline tests on ubuntu-latest#1283
Merged
Merged
Conversation
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
jku
pushed a commit
to jku/sigstore-python
that referenced
this pull request
Oct 14, 2025
jku
pushed a commit
to jku/sigstore-python
that referenced
this pull request
Oct 14, 2025
Backport of sigstore#1283 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
added a commit
that referenced
this pull request
Oct 24, 2025
* Backport: internal/trust: Fix bug in rekor key lookup Rekor keyring can (and in future will) have multiple keys: logs not only get sharded but once rekor-tiles is integrated in the public good instance, there will be two writable logs for a while. Backport of #1350 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * Backport #1424 Fail less hard when unsupported keys are seen Current trusted root contains keys this client version does not understand: the keys are not necessary to verify or sign bundles with rekor v1 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * Backport: ci: fix offline tests on ubuntu-latest Backport of #1283 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * Bump 3.5.x series to 3.5.4 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> --------- Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> Co-authored-by: William Woodruff <william@trailofbits.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP.This "fixes" the CI by effectively undoing the namespace default changes that Ubuntu made between 22.04 and 24.04. Doing this should have no security impact in practice, since we're already running with full root access on these runners.
The other option here would be to remove
unshareentirely, and continue to test the offline tests without actually enforcing their offline-ness. However, I think it's good to keep this around as a backstop, at least for as long as we can 🙂