Backport trust root fixes to 3.5.x#1578
Merged
Merged
Conversation
Rekor keyring can (and in future will) have multiple keys: logs not only get sharded but once rekor-tiles is integrated in the public good instance, there will be two writable logs for a while. Backport of sigstore#1350 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Fail less hard when unsupported keys are seen Current trusted root contains keys this client version does not understand: the keys are not necessary to verify or sign bundles with rekor v1 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Backport of sigstore#1283 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
3d16ab4 to
01c96b3
Compare
Member
Author
|
I'll still do the version bump and changelog update in this PR if we want to do this |
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Member
Author
|
I'm marking this ready for review even though I'm not 100% sure we should do this:
|
Member
Same -- I'm personally OK with merging this, but we should put a note in the CHANGELOG explaining that this does not not imply ongoing support for the 3.5.x series 🙂 |
di
approved these changes
Oct 23, 2025
Member
Agreed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would say I generally don't want to actively maintain more than two series at the same time... However to get #1575 started on the right foot we could still do a patch release of 3.5.x (and then make it clear it's unsupported).
CC @di this is your idea from #1575