Merged
Conversation
8c6be8a to
ad7a6d8
Compare
Member
|
Working on builder and beacon API changes here: pawanjay176#9 |
…hthouse into sidecar-inclusion-api-updates
Sidecar inclusion api updates
jimmygchen
reviewed
Dec 1, 2023
jimmygchen
reviewed
Dec 1, 2023
jimmygchen
reviewed
Dec 1, 2023
jimmygchen
reviewed
Dec 1, 2023
jimmygchen
reviewed
Dec 1, 2023
jimmygchen
reviewed
Dec 1, 2023
jimmygchen
reviewed
Dec 1, 2023
jimmygchen
reviewed
Dec 1, 2023
jimmygchen
reviewed
Dec 1, 2023
jimmygchen
reviewed
Dec 1, 2023
* Update some comments, variables and small cosmetic fixes. * Couple blobs and proofs into a tuple in `PayloadAndBlobs` for simplicity and safety. * Update function comment.
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
…dates Sidecar inclusion review updates
jimmygchen
approved these changes
Dec 4, 2023
Member
jimmygchen
left a comment
There was a problem hiding this comment.
Nice! I've finished my review, I think it might be helpful to merge this one once others have finished reviewing - to make reviews on further changes a bit easier. (It's hard to keep track of what's reviewed when the PR is already quite large)
Just a few comments left:
- @michaelsproul 's comment on simplifying the finalized descendant parent block check here
- Suggestion on renaming the beacon API types here
- Potential duplicate headers provided to slasher here
Merged
Fix slasher conditions
Rename the block and blob wrapper types used in the beacon API interfaces
3 tasks
Member
Author
|
Addressed all comments |
realbigsean
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Implements ethereum/consensus-specs#3531
Proposed Changes
Refactors deneb code to include sidecar inclusion proofs.
SignedvariantsSignedvariantbeacon_chainto work with new typesThis isn't an exhaustive list and I expect to keep updating it since the linked spec changes are also getting updated.
Changes to one item are likely to leak into other items. Looking to get the PR to a stable state where everything compiles and we can then focus on more specific things.
Making an early WIP PR since other folks also wanted to work on the changes.