Rename the block and blob wrapper types used in the beacon API interfaces#4974
Merged
realbigsean merged 1 commit intosigp:sidecar-inclusion-prooffrom Dec 4, 2023
Merged
Conversation
Member
|
Good idea! Makes it more clear these are meant to map to HTTP reqs and resps |
realbigsean
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Suggestion to rename these two Beacon API types, as I'm still feeling a bit confused and need to look at the code to understand what these types are for:
BlockContentsWrapper->ProduceBlockV3Response: response fromGET v3/validator/blocksFullSignedBlockContents->PublishBlockRequest: request body forPOST beacon/blocks