Fix slasher conditions#4976
Merged
realbigsean merged 3 commits intosigp:sidecar-inclusion-prooffrom Dec 4, 2023
Merged
Conversation
realbigsean
reviewed
Dec 4, 2023
|
|
||
| #[derive(Debug, Default)] | ||
| pub struct BlockQueue { | ||
| blocks: Mutex<Vec<SignedBeaconBlockHeader>>, |
Member
|
Nice! I think this just needs a |
realbigsean
approved these changes
Dec 4, 2023
Member
|
HashSet is fine for blocks I think, we just process them in a loop here: lighthouse/slasher/src/slasher.rs Lines 100 to 106 in 441fc16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses #4900 (comment)
Thanks @jimmygchen
Proposed Changes
Previously, we were adding a
BlobSidecar's header to the slasher under the following conditions:These conditions do not cover all cases since a valid gossip blob with an equivocating header that gets into the
observed_blob_cachewill not fail gossip verification and will never be fully available since the proposer need not propagate the full signed equivocating block. Such aBlobSidecarwith a slashable block header will just go sit in the DA cache and eventually get pruned.Hence, this PR adds the signed header before adding the blobs to the DA cache.
I have also changed the
BlockQueuedata structure to be aHashSetinstead of aVecsince we are adding potentially many duplicate headers per slot. Looking at the slasher code, I don't think changing the data structure is an issue, please correct me if that's wrong or unnecessary @michaelsproul