chore(package): remove v0.8 from engines list#308
Merged
ariporad merged 1 commit intoshelljs:masterfrom Jan 25, 2016
nfischer:fix-package-json
Merged
chore(package): remove v0.8 from engines list#308ariporad merged 1 commit intoshelljs:masterfrom nfischer:fix-package-json
ariporad merged 1 commit intoshelljs:masterfrom
nfischer:fix-package-json
Conversation
Contributor
|
I don't think we support anything less than <0.12, do we? (I think travis only builds 0.12 and up) |
Member
Author
|
@ariporad the travis config uses This can be verified by looking at the travis output where it says |
Contributor
|
@nfischer: no, I know, but is our build set up to build on node 0.10? (Sorry, on mobile, so I can't check) |
Member
Author
|
@ariporad Yeah, our travis config uses v0.10, 0.11, 0.12, 4, and 5 |
Contributor
|
Ok then. LGTM! |
ariporad
added a commit
that referenced
this pull request
Jan 25, 2016
chore(package): remove v0.8 from engines list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't really guarantee our stuff works on v0.8, since travis doesn't run on that version (this is because jshint requires v0.10+). So this just removes it from package.json. This doesn't prevent v0.8 users from using shelljs, just removes the promise of support.
See #307 for a discussion about this.