Skip to content

Replace c_void_p with c_geom_p#1479

Merged
sgillies merged 2 commits intomaint-1.8from
geometry-pointer
Aug 16, 2022
Merged

Replace c_void_p with c_geom_p#1479
sgillies merged 2 commits intomaint-1.8from
geometry-pointer

Conversation

@sgillies
Copy link
Copy Markdown
Contributor

@sgillies sgillies commented Aug 16, 2022

In an attempt to fix the issue reported in #1449 and perhaps solved in django/django#15214.

@sgillies
Replace c_void_p with c_geom_p
48ed8cc 
In an attempt to fix the issue reported in #1449 and perhaps solved
in django/django#15214.
@sgillies sgillies added this to the 1.8.3 milestone Aug 16, 2022
@sgillies sgillies self-assigned this Aug 16, 2022
@jorisvandenbossche
Copy link
Copy Markdown
Member

jorisvandenbossche commented Aug 16, 2022

FYI the windows failures are not related, will be fixed by #1481

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 16, 2022

Pull Request Test Coverage Report for Build 2869144536

  • 49 of 49 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 85.881%
Totals Coverage Status
Change from base Build 2836128133: 0.04%
Covered Lines: 3023
Relevant Lines: 3520
💛 - Coveralls

@sgillies sgillies mentioned this pull request Aug 16, 2022
Merged
@sgillies
Copy link
Copy Markdown
Contributor Author

sgillies commented Aug 16, 2022

I believe we have parity with GeoDjango here. Tests pass. I'll merge, ask for some testing of the maint-1.8 dev wheels, and then make a 1.8.3 release later today.

@sgillies sgillies merged commit 3845418 into maint-1.8 Aug 16, 2022
@sgillies sgillies deleted the geometry-pointer branch August 16, 2022 15:49
@jorisvandenbossche jorisvandenbossche mentioned this pull request Aug 17, 2022
Closed
sgillies added a commit that referenced this pull request Aug 17, 2022
@sgillies
Revert "Replace c_void_p with c_geom_p (#1479)"
6945035 
This reverts commit 3845418.
@sgillies sgillies mentioned this pull request Aug 17, 2022
Merged
sgillies added a commit that referenced this pull request Aug 17, 2022
@sgillies
Revert "Replace c_void_p with c_geom_p" (#1487)
57432f9 
* Revert "Replace c_void_p with c_geom_p (#1479)"

This reverts commit 3845418.

* Remove c_geom_p
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sgillies sgillies

Labels

None yet

Projects

None yet

Milestone

1.8.3

Development

Successfully merging this pull request may close these issues.

3 participants

@sgillies @jorisvandenbossche @coveralls