Skip to content

Revert "Replace c_void_p with c_geom_p"#1487

Merged
sgillies merged 2 commits intomaint-1.8from
revert-1479-geometry-pointer
Aug 17, 2022
Merged

Revert "Replace c_void_p with c_geom_p"#1487
sgillies merged 2 commits intomaint-1.8from
revert-1479-geometry-pointer

Conversation

@sgillies
Copy link
Copy Markdown
Contributor

Reverts #1479, which didn't fix the issue it intended to fix.

@sgillies sgillies added this to the 1.8.4 milestone Aug 17, 2022
@sgillies sgillies added the bug label Aug 17, 2022
@jorisvandenbossche
Copy link
Copy Markdown
Member

A subsequent commit also made use of this: 088ce60 (would need to be reverted as well)

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2878080878

  • 45 of 45 (100.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 85.844%

Totals Coverage Status
Change from base Build 2872044967: -0.05%
Covered Lines: 3014
Relevant Lines: 3511

💛 - Coveralls

@sgillies sgillies merged commit 57432f9 into maint-1.8 Aug 17, 2022
@jorisvandenbossche jorisvandenbossche deleted the revert-1479-geometry-pointer branch August 17, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants