-
Notifications
You must be signed in to change notification settings - Fork 269
Shadow writes the wrong TCP header length in pcap files #2619
Copy link
Copy link
Closed
Labels
Component: ToolsPeripheral tools like parsing log files or visualizing resultsPeripheral tools like parsing log files or visualizing resultsType: BugError or flaw producing unexpected resultsError or flaw producing unexpected results
Milestone
Description
Describe the issue
Shadow writes the wrong TCP header length in pcap files
Additional context
Shadow currently reports that the TCP segment length is 32 bytes. That's wrong: TCP header sizes are currently 20 bytes.
Here's the offending line:
shadow/src/main/network/packet.rs
Line 202 in 894a63c
| let header_len: u8 = 0x80; |
This should instead match the CONFIG_HEADER_SIZE_TCP macro constant defined in definitions.h.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Component: ToolsPeripheral tools like parsing log files or visualizing resultsPeripheral tools like parsing log files or visualizing resultsType: BugError or flaw producing unexpected resultsError or flaw producing unexpected results