Skip to content

Issue 2619; fixes TCP header sizes in pcap files#2620

Merged
rwails merged 2 commits intoshadow:mainfrom
rwails:iss2619
Dec 28, 2022
Merged

Issue 2619; fixes TCP header sizes in pcap files#2620
rwails merged 2 commits intoshadow:mainfrom
rwails:iss2619

Conversation

@rwails
Copy link
Copy Markdown
Collaborator

@rwails rwails commented Dec 19, 2022 •
edited by robgjansen
Loading

Fixes #2619

@rwails rwails requested a review from stevenengler December 19, 2022 21:09
@rwails rwails self-assigned this Dec 19, 2022
@rwails rwails added the Component: Tools Peripheral tools like parsing log files or visualizing results label Dec 19, 2022
@rwails rwails linked an issue Dec 19, 2022 that may be closed by this pull request
Shadow writes the wrong TCP header length in pcap files #2619
Closed
@rwails rwails added this to the Code health and maintenance milestone Dec 19, 2022
@github-actions github-actions bot added Component: Main Composing the core Shadow executable and removed Component: Tools Peripheral tools like parsing log files or visualizing results labels Dec 19, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 19, 2022 •
edited
Loading

Codecov Report

Base: 68.16% // Head: 67.97% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (9f567e0) compared to base (1b89702).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
- Coverage   68.16%   67.97%   -0.19%     
==========================================
  Files         201      201              
  Lines       29496    29498       +2     
  Branches     5790     5790              
==========================================
- Hits        20106    20052      -54     
- Misses       4777     4842      +65     
+ Partials     4613     4604       -9
Flag Coverage Δ
tests 67.97% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/network/packet.rs 20.89% <0.00%> (-0.32%) ⬇️
src/main/host/syscall/handler/fcntl.rs 50.00% <0.00%> (-15.72%) ⬇️
src/main/host/descriptor/descriptor_table.rs 69.56% <0.00%> (-10.15%) ⬇️
src/main/host/syscall/handler/unistd.rs 66.00% <0.00%> (-7.12%) ⬇️
src/main/utility/shm_cleanup.rs 59.09% <0.00%> (-5.69%) ⬇️
src/main/core/scheduler/pools/unbounded.rs 77.90% <0.00%> (-4.07%) ⬇️
src/main/core/logger/shadow_logger.rs 67.25% <0.00%> (-2.93%) ⬇️
src/main/host/syscall/handler/mod.rs 83.75% <0.00%> (-2.50%) ⬇️
src/main/core/scheduler/thread_per_core.rs 88.11% <0.00%> (-1.40%) ⬇️
src/main/core/manager.rs 63.16% <0.00%> (-1.34%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

stevenengler
stevenengler approved these changes Dec 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@stevenengler
Copy link
Copy Markdown
Contributor

stevenengler commented Dec 22, 2022

(Rebasing should fix the CI failure.)

@rwails
Copy link
Copy Markdown
Collaborator Author

rwails commented Dec 28, 2022

I also corrected the pcap writer to not produce TCP options fields as they are not being used right now

@rwails rwails merged commit 1b671c3 into shadow:main Dec 28, 2022
@rwails rwails deleted the iss2619 branch December 28, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@rwails rwails

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

Shadow writes the wrong TCP header length in pcap files

2 participants

@rwails @stevenengler