Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
/rerun-test test_streaming_session_unit.py test_preset.py test_code_patcher.py test_dumper_integration.py test_source_editor.py test_dump_comparator.py |
|
✅ ✅ |
|
✅ ✅ |
|
✅ ✅ |
|
✅ ✅ |
|
✅ |
|
/tag-and-rerun-ci |
|
Why are the tests removed? Does it not mean that some part of sglang codebase still exist, but are simply untested? The intent was definitely not to have tests skipped by default when adding tests to |
Re-add the int4fp8_moe quantization accuracy test (Mixtral-8x7B, GSM8K) that was removed in #23305. The original file (from #17116 / #7392) was missing an `if __name__ == "__main__": unittest.main()` block, causing it to silently skip in CI. This commit restores the test with a proper `__main__` entry. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
Hi @fxmarty-amd , in this PR #23305 your test file will be restored and properly registered. |
… fix rerun-test protoc (sgl-project#23305)
… fix rerun-test protoc (sgl-project#23305)
Misc CI hygiene bundle. Three independent changes:
1. Sanity check + streaming test fix
Pytest-style tests under
test/registered/have been silently skipping in CI: the CI runner invokes each file viapython3 file.py -f(not pytest), so files without an executableif __name__ == "__main__":block just import and exit zero. Every test function body has never run.collect_tests: every registered file with at least one enabled registry must have an executable__main__block (AST-verified). Files with all registriesdisabled=...(helpers, self-skipping multi-GPU benches) are exempt._FakeReq.finished_len = None(missing from fixture; realReqdefaults toNone) + proper__main__entry. Also dropped a stale test (defers_tail_free) whose intent was already superseded by streaming session: trim spec v2 overshoot in cache_finished_req #22897.Root cause (for context)
run_unittest_files->subprocess.Popen(["python3", <file>, "-f"])— assumesunittest.main()picks up-fas--failfast.unittest.main()/ no__main__block just import + exit 0. Zero tests executed, CI shows green.Kept files (6):
__main__fix applied, tests now actually runtest/registered/unit/mem_cache/test_streaming_session_unit.py— PR's immediate target (4 tests)test/registered/debug_utils/comparator/test_preset.pytest/registered/debug_utils/source_patcher/test_code_patcher.pytest/registered/debug_utils/source_patcher/test_dumper_integration.pytest/registered/debug_utils/source_patcher/test_source_editor.pytest/registered/debug_utils/test_dump_comparator.py— also droppedTestMainBasicsubset: those 3 integration tests calldump_comparator.main()which hard-codesx.cuda()in_load_tensor, so they always raiseno NVIDIA driveron the CPU suite they were registered in. Kept the 6 pure-CPU unit tests in the file. cc @fzyzcjy (originally added in Tiny fix single-gpu dumper and add tests for dumper #16285)Dropped files (9)
test/registered/quant/test_bnb.py— cc @yhyang201test/registered/quant/test_int4fp8_moe.py— cc @fxmarty-amd (content [AMD][Quantization] Addint4fp8_moeonline quantization on ROCm #7392), @Ying1123 (framework Add accuracy test to CI: MMLU #882)test/registered/amd/test_zimage_turbo.py— cc @michaelzhang-aipython/sglang/jit_kernel/tests/test_dependency.py— cc @DarkSharpnesstest/registered/ops/test_repeat_interleave.py— cc @yuan-luotest/registered/unit/function_call/test_glm47_moe_detector.py— cc @Leoyzentest/registered/unit/model_executor/test_model_hooks.py— cc @Carlomustest/registered/rotary/test_mrope.py— cc @yuan-luo (initial), @raayandhar (yarn feat feat: Supportmrope_sectionwithrope_type: "yarn"#13313)test/registered/vlm/test_patch_embed_perf.py— perf assertion (linear-vs-conv3d speedup), prone to flakiness on shared GPU runners; silent-skip since day one. cc @yuan-luoIf any original author wants a file revived: reopen with a proper
__main__block (see the pattern intest_streaming_session_unit.pyat the bottom) so the file actually executes in CI.2. Fix
rerun-test.ymlCPU job missingprotoc/rustuprerun-test-cpu(.github/workflows/rerun-test.yml) wasruns-on: ubuntu-latestbut missing theInstall protoc+Install Rust toolchainsteps thatpr-test.yml'sstage-a-test-cpuhas (at pr-test.yml:646-652). Installingsglangeditable wheel compilessglang-grpcRust crate, whosebuild.rsneedsprotoc-> workflow fails inInstall dependenciesbefore pytest even starts.Fix: mirror
pr-test.yml's setup — add the same two steps. Keeps rerun-test environment aligned with pr-test rather than forking into a docker-container approach.Test plan
collect_tests(sanity_check=True)passes over all 710 registered filesscripts/ci/check_registered_tests.pyreturns 0 (pre-commit hook stays green)/rerun-test)