Skip to content

Tiny fix single-gpu dumper and add tests for dumper#16285

Merged
fzyzcjy merged 30 commits intosgl-project:mainfrom
fzyzcjy:feat/dumper_test
Jan 2, 2026
Merged

Tiny fix single-gpu dumper and add tests for dumper#16285
fzyzcjy merged 30 commits intosgl-project:mainfrom
fzyzcjy:feat/dumper_test

Conversation

@fzyzcjy
Copy link
Copy Markdown
Collaborator

@fzyzcjy fzyzcjy commented Jan 2, 2026

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Jan 2, 2026

Summary of Changes

Hello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the sglang dumper utility by ensuring its compatibility and correct behavior in single-GPU execution environments. Crucially, it significantly expands the project's testing infrastructure with a suite of new unit and end-to-end tests for the dumper, dump_comparator, and dump_loader components. These additions improve the reliability and maintainability of the debugging tools, providing a more stable foundation for development and troubleshooting.

Highlights

  • Single-GPU Dumper Compatibility: The dumper utility's distributed communication logic has been updated to correctly handle single-GPU environments by conditionally checking if torch.distributed is initialized before attempting distributed operations.
  • Comprehensive Dumper Testing: New unit and end-to-end tests have been introduced for the core dumper module, covering functionalities such as value truncation, object serialization, tensor information extraction, and various distributed dumping scenarios (e.g., HTTP control, filtering, write-disabled).
  • Dump Comparator Tests Added: Dedicated tests are now included for the dump_comparator utilities, ensuring accurate calculation of relative differences, argmax coordinates, shape unification, dtype computation, and einops pattern parsing.
  • Dump Loader Tests Added: New tests have been implemented for the dump_loader module, verifying the correct functionality of reading metadata, finding rows in DataFrames, casting to Polars dtypes, and handling duplicate indices.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a fix for the dumper to support single-GPU environments and adds a comprehensive suite of tests for the dumper and its related utilities. The fix in dumper.py is sound and correctly handles the non-distributed case. The new tests are well-structured and significantly improve code coverage. My review focuses on the configuration of these new tests, where I've identified a few mismatches in CI registration that could lead to CI failures or inefficient resource usage. The proposed changes are otherwise excellent.

Comment thread test/registered/debug_utils/test_dumper.py Outdated
Comment thread test/registered/debug_utils/test_dump_comparator.py Outdated
Comment thread test/registered/debug_utils/test_dump_loader.py Outdated
@fzyzcjy
Copy link
Copy Markdown
Collaborator Author

fzyzcjy commented Jan 2, 2026 •
edited
Loading

/gemini review

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds support for single-GPU execution in the dumper utility by handling cases where torch.distributed is not initialized. The addition of comprehensive test suites for the dumper, dump loader, and dump comparator is a great improvement and significantly increases the reliability of these debugging tools. My review focuses on a few minor improvements in the new test files to enhance their robustness, specifically regarding resource management of temporary directories and avoiding hardcoded network ports to prevent potential test flakiness.

Comment thread test/registered/debug_utils/test_dumper.py Outdated
Comment thread test/registered/debug_utils/test_dumper.py Outdated
Comment thread test/registered/debug_utils/test_dumper.py Outdated
Comment thread test/registered/debug_utils/test_dumper.py
fzyzcjy and others added 3 commits January 2, 2026 13:26
@fzyzcjy @gemini-code-assist
Update test/registered/debug_utils/test_dumper.py
785e640 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@fzyzcjy @gemini-code-assist
Update test/registered/debug_utils/test_dumper.py
c0604c3 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@fzyzcjy @gemini-code-assist
Update test/registered/debug_utils/test_dumper.py
b3f0ee6 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@fzyzcjy fzyzcjy merged commit 749736b into sgl-project:main Jan 2, 2026
60 of 67 checks passed
yingluosanqian pushed a commit to yingluosanqian/sglang that referenced this pull request Jan 4, 2026
@fzyzcjy @yingluosanqian
Tiny fix single-gpu dumper and add tests for dumper (sgl-project#16285)
a324575
YChange01 pushed a commit to YChange01/sglang that referenced this pull request Jan 13, 2026
@fzyzcjy @YChange01
Tiny fix single-gpu dumper and add tests for dumper (sgl-project#16285)
dac6400
@hnyls2002 hnyls2002 mentioned this pull request Apr 21, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fzyzcjy