Skip to content

Tiny avoid EnvField misuse#15612

Merged
fzyzcjy merged 1 commit intosgl-project:mainfrom
fzyzcjy:feat/env_assert
Dec 22, 2025
Merged

Tiny avoid EnvField misuse#15612
fzyzcjy merged 1 commit intosgl-project:mainfrom
fzyzcjy:feat/env_assert

Conversation

@fzyzcjy
Copy link
Copy Markdown
Collaborator

@fzyzcjy fzyzcjy commented Dec 22, 2025

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Dec 22, 2025

Summary of Changes

Hello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a small but important change to prevent potential misuse of the EnvField class within the sglang environment configuration. By introducing a controlled mechanism for EnvField instance naming, it ensures that environment variables are set up correctly during initialization and prevents unintended modifications or assignments later in the application lifecycle, enhancing the robustness of the environment management system.

Highlights

  • Prevent EnvField Misuse: Introduced a class-level flag _allow_set_name within the EnvField class to control when its __set_name__ method can be invoked, thereby preventing unintended dynamic assignments.
  • Enforce Correct Usage: Added an assertion inside EnvField.__set_name__ that triggers an error if _allow_set_name is False, specifically targeting and disallowing direct assignments like a = envs.A after initialization.
  • Finalize EnvField Setup: Set EnvField._allow_set_name to False immediately after the envs singleton object is initialized, ensuring that all EnvField instances are properly configured and cannot be misused thereafter.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to prevent defining new EnvFields after the initial envs object is created. This is a good practice as it centralizes all environment variable definitions. The implementation uses a class-level flag that is flipped after initialization. My review focuses on improving developer experience by making the new assertion message more accurate and helpful.

Comment thread python/sglang/srt/environ.py
@fzyzcjy fzyzcjy merged commit 89619a9 into sgl-project:main Dec 22, 2025
57 of 64 checks passed
Liwansi added a commit to iforgetmyname/sglang that referenced this pull request Dec 23, 2025
@Liwansi
Merge branch 'main' of https://github.com/sgl-project/sglang into qwe…
d2ed9e6 
…n_eagle3_dp

* 'main' of https://github.com/sgl-project/sglang: (208 commits)
  MoE: Skip SiLU/GELU activation for masked experts (sgl-project#15539)
  [GLM-ASR] GLM-ASR Support  (sgl-project#15570)
  Improve engine customization interface (sgl-project#15635)
  chore: bump sgl-kernel version to 0.3.20 (sgl-project#15590)
  bugfix[schedule]: Refactor sort method and add related UT (sgl-project#13576)
  Adjust wrong `mtp` meaning introduce by mimo (sgl-project#15632)
  Tiny add back missing router per attempt response metric (sgl-project#15621)
  Fix router gRPC mode launch error caused by async loading (sgl-project#15368)
  [model-gateway] return 503 when all workers are circuit-broken (sgl-project#15611)
  [Diffusion] Support peak memory record in offline generate and serving (sgl-project#15610)
  [VLM] Tiny: Unify VLM environment variables (sgl-project#15572)
  [diffusion] chore: remove default post-denoising dit offload in local mode (sgl-project#15573)
  Tiny enable soft watchdog in CI for stuck without logs (sgl-project#15616)
  Tiny add stuck simulation (sgl-project#15613)
  Support soft watchdog for tokenizer/detokenizer/dp-controller processes (sgl-project#15607)
  Tiny avoid EnvField misuse (sgl-project#15612)
  add decode round robin policy (sgl-project#15164)
  Add glm-4.6-fp8 with/without mtp in nightly ci (sgl-project#15566)
  Adapt fixture-kit to gsm8k mixin (sgl-project#15599)
  [model-gateway] add retry support to OpenAI router chat endpoint (sgl-project#15589)
  ...
jiaming1130 pushed a commit to zhuyijie88/sglang that referenced this pull request Dec 25, 2025
@fzyzcjy @jiaming1130
Tiny avoid EnvField misuse (sgl-project#15612)
b7ad723
YChange01 pushed a commit to YChange01/sglang that referenced this pull request Jan 13, 2026
@fzyzcjy @YChange01
Tiny avoid EnvField misuse (sgl-project#15612)
9c2e58b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fzyzcjy