[Feature, Hardware] Enable SGLang on AMD GPUs via PyTorch for ROCm#1420
Merged
merrymercy merged 8 commits intosgl-project:mainfrom Sep 17, 2024
HaiShaw:main
Merged
[Feature, Hardware] Enable SGLang on AMD GPUs via PyTorch for ROCm#1420merrymercy merged 8 commits intosgl-project:mainfrom HaiShaw:main
merrymercy merged 8 commits intosgl-project:mainfrom
HaiShaw:main
Conversation
29 tasks
merrymercy
requested changes
Sep 14, 2024
Contributor
There was a problem hiding this comment.
- We deprecated
--disable-flashinfer --disable-flashinfer-sampling. Please use--attention-backend triton --sampling-backend pytorchinstead. - Alternatively, you can set these backends automatically here https://github.com/HaiShaw/sglang/blob/8715deff22727382ce6f74768213e3e72f413f71/python/sglang/srt/server_args.py#L155
if is_hip():
self.attention_backend = "triton"
self.sampling_backend = "pytorch"- The sampler + cuda graph issue has been fixed by #1392. You can rebase and try it again.
python -m sglang.bench_latency --model-path TinyLlama/TinyLlama-1.1B-Chat-v0.4 --attention-backend triton --sampling-backend pytorchThis runs correctly.
merrymercy
requested changes
Sep 16, 2024
merrymercy
reviewed
Sep 17, 2024
merrymercy
approved these changes
Sep 17, 2024
2 tasks
|
rocm 6.1.2 |
Contributor
|
@linqingxu try |
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Bypass
FlashInferbackend untill it is available on AMD/ROCmAdd proper fix for AMD FP8
e4m3fnuzto support Fused_MoEDependency over
vLLM>=0.5.5, I modifiedpyproject.tomljust to confirm that it works up to 0.6.0 as well.Misc.
TODO: follow-up to address one error (below) when
cuda-graphis enabled.How to run
Checklist