Optimize conflicts between CUDA graph and vocab mask tensors#1392
Merged
merrymercy merged 11 commits intomainfrom Sep 14, 2024
Merged
Optimize conflicts between CUDA graph and vocab mask tensors#1392merrymercy merged 11 commits intomainfrom
merrymercy merged 11 commits intomainfrom
Conversation
0d2f2c5 to
1ef88ff
Compare
09c900d to
92b9594
Compare
6e20c93 to
4f0d0cb
Compare
4f0d0cb to
e893a95
Compare
f46a050 to
3273d3f
Compare
01486b3 to
184e444
Compare
3 tasks
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR moves the sampler out of the CUDA graph and removes the synchronization in the cuda graph replay.
Modifications
Checklist