[BEAM-5077] Translators now use type information from Operators to set Coders#16
Merged
VaclavPlajt merged 3 commits intosimunek/typesfrom Aug 20, 2018
Merged
Conversation
…never possible. Way coders are resolved was refactored.
…rry mapping from `Pair` to `KV` in `ReduceByKeyTranslator`removed. Some other references to `Pair` in comments and methods or variable names modified to `KV`.
dmvk
pushed a commit
that referenced
this pull request
Aug 17, 2018
dmvk
pushed a commit
that referenced
this pull request
Aug 17, 2018
[BEAM-5099] Replace Euphoria's Pair with Beam's KV
dmvk
pushed a commit
that referenced
this pull request
Oct 5, 2018
dmvk
pushed a commit
that referenced
this pull request
Oct 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a way coders are resolved was refactored according to suggestions from BEAM-5077.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)