Skip to content

[BEAM-5099] Replace Euphoria's Pair with Beam's KV#17

Merged
VaclavPlajt merged 1 commit intovasek/coders-resolvefrom
vasek/pair_to_KV
Aug 20, 2018
Merged

[BEAM-5099] Replace Euphoria's Pair with Beam's KV#17
VaclavPlajt merged 1 commit intovasek/coders-resolvefrom
vasek/pair_to_KV

Conversation

@VaclavPlajt
Copy link
Copy Markdown

@VaclavPlajt VaclavPlajt commented Aug 7, 2018

See BEAM-5099.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

…rry mapping from `Pair` to `KV` in `ReduceByKeyTranslator`removed. Some other references to `Pair` in comments and methods or variable names modified to `KV`.
Copy link
Copy Markdown

@dmvk dmvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@VaclavPlajt VaclavPlajt merged commit 97cca27 into vasek/coders-resolve Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants