servoshell: Fix stdout / stderr output in windows production builds #40961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
…dows-sys` (#40980) In #40961, we start to use `windows_sys::Win32::System::Console;`. This is gated behind `Win32_System_Console` feature. We didn't have the problem merging that one, because it was luckily enabled by some other dependencies. But @dependabot can act weird: #40979, which would break the build from time to time. See https://github.com/servo/servo/actions/runs/19816434323/job/56768628158. Fixes: Treacherous bug that is only revealed when other crates's `windows-sys` is downgraded. --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When servo is started from the command line, we still want output to be printed. On windows, due to us using the
windowssubsystem (as opposed to the defaultconsolesubsystem), this doesn't work out-of-the-box, and we need to manually attempt to attach to the console of the parent process. If servo was not started from the command line, then the call will fail, which we can ignore.Since we can now have the best of both worlds (i.e no popping up console window, and preserve stdout / stderr when started from a console), we can now unconditionally use the
windowssubsystem. (On non-windows platforms,windows-subsystemdoes nothing)Testing: Manually tested. The original issue does not reproduce when redirecting stdout / stderr, so I don't see a way to write an automated test.
Fixes: #40211