script: Improve spec-compliance of Performance resource timing entries #40811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
…e buffer directly. Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Taym95
approved these changes
Nov 22, 2025
TimvdLippe
approved these changes
Nov 22, 2025
Contributor
TimvdLippe
left a comment
There was a problem hiding this comment.
Nice fix and spec comments!
mukilan
approved these changes
Nov 22, 2025
Contributor
|
Ah seems like Tay's and my review crossed in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't match the specification and is broken in a way that makes nytimes.com endlessly attempt to enqueue resource timing entries, making the page completely unresposive to user input. This PR makes some surgical changes that fix the NYTimes behaviour and add some comments to make it easier to further improve the implementation in the future.
Testing: Various WPT that used to timeout now fail instead.
Fixes: #40808