script: Replace strings for performance entry types with dedicated enum. #40812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
commented
Nov 22, 2025
| @@ -1,4 +1,6 @@ | |||
| [cors-preflight.any.html] | |||
| expected: ERROR | |||
Member
Author
There was a problem hiding this comment.
This is triggered by a preexisting bug where we store too many resource performance entries. These changes just expose it.
70dd827 to
ff63058
Compare
mukilan
approved these changes
Nov 22, 2025
ff63058 to
e85cfa2
Compare
e85cfa2 to
c53cd58
Compare
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
c53cd58 to
c804696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both reduces unnecessary string comparisons and fixes several cases where two string arguments were passed in the wrong order.
Depends on #40811.
Testing: New passing tests.