devtools: Frame actor boilerplate #40791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
8062781 to
bbb1c81
Compare
mrobinson
approved these changes
Nov 21, 2025
Signed-off-by: eri <eri@igalia.com>
bbb1c81 to
9e7f93b
Compare
Contributor
Author
|
Rebased and removed the dead code allow from the environment actor. The one here and the one in pause will be removed with the changes in the thread actor. |
jdm
approved these changes
Nov 23, 2025
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| // TODO: Remove once the actor is used. |
Member
There was a problem hiding this comment.
Suggested change
| // TODO: Remove once the actor is used. |
Signed-off-by: eri <eri@igalia.com>
delan
added a commit
that referenced
this pull request
Nov 24, 2025
{"fail_fast": false, "matrix": [{"name": "Windows", "workflow": "windows", "wpt": false, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}, {"name": "Linux", "workflow": "linux", "wpt": false, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}, {"name": "Lint", "workflow": "lint", "wpt": false, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prequisite for implementing pausing in the debugger. This will be part of the
ThreadActorresponse tointerrupt. Continuation of #38824.Depends on #40787 for
EnvironmentActor*.Testing: Deferred until the pause is fully implemented.
Fixes: Part of #36027.