devtools: Add Environment actor boilerplate and Object actor encode #40787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f19e106 to
22f5540
Compare
Signed-off-by: eri <eri@igalia.com>
22f5540 to
84e1da4
Compare
Signed-off-by: eri <eri@igalia.com>
mrobinson
approved these changes
Nov 21, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
It's a little sad to add dead code, but I understand that you will address it soon.
Contributor
Author
|
Yes, it's part of a larger patch that I'm working on. But making a PR with all at once would be too much to review. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
Prequisite for implementing pausing in the debugger. This will be part of the `ThreadActor` response to `interrupt`. Continuation of #38824. Depends on #40787 for `EnvironmentActor*`. Testing: Deferred until the pause is fully implemented. Fixes: Part of #36027. --------- Signed-off-by: eri <eri@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prequisite for implementing pausing in the debugger. The
EnvironmentActorwill be used in the future from theFrameActor, we need the struct defined to start to implement it.The
ObjectActorMsgis not only used by theEnvoironmentActor, but also by theThreadActorwhen replying tointerrupt.Testing: Deferred until the pause is fully implemented.
Fixes: Part of #36027.