Add routing and security configuration to AcmeDemoBundle#120
Add routing and security configuration to AcmeDemoBundle#120romainneutron wants to merge 3 commits intosensiolabs:masterfrom
Conversation
Composer/ScriptHandler.php
Outdated
There was a problem hiding this comment.
what about renaming secured_area to demo_secured_idea to make it clearer that it is a firewall related to the demo ?
There was a problem hiding this comment.
I like that. Prefixing everything with demo_ would make it easier for the developer to remove things he does not need to keep.
|
I've updated the PR. It addresses @stof comment. I've also dropped the use of the Yaml component. |
Composer/ScriptHandler.php
Outdated
There was a problem hiding this comment.
That's very fragile as it means that the user actually stored this file in his repository. If not, the question will be asked when the user deploy their website. Any other way (via Composer) to know if we've been called via create-project?
There was a problem hiding this comment.
composer plugins can hook in the composer command, but there is no way to run a composer script only at this time
…onBundle (romainneutron) This PR was squashed before being merged into the 2.4-dev branch (closes #645). Discussion ---------- Move Acme demo bundle configuration to sensio DistributionBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | License | MIT This is related to sensiolabs/SensioDistributionBundle#120 Commits ------- 0d8d160 Move Acme demo bundle configuration to sensio DistributionBundle
This follows #119
I'm not sur of the right implementation: I'm using the Yaml component that strips blank lines and comments. As the AcmeDemoBundle is supposed to be used by newcomers, I don't think that losing readability and comments in these config files is a good thing.