This repository was archived by the owner on Jan 6, 2020. It is now read-only.
Import Acme demo bundle from symfony standard edition#119
Merged
fabpot merged 1 commit intosensiolabs:masterfrom Mar 30, 2014
Merged
Import Acme demo bundle from symfony standard edition#119fabpot merged 1 commit intosensiolabs:masterfrom
fabpot merged 1 commit intosensiolabs:masterfrom
Conversation
Contributor
Author
|
See test instructions in symfony/symfony-standard#643 |
fabpot
added a commit
that referenced
this pull request
Mar 30, 2014
…omainneutron) This PR was merged into the 3.0.x-dev branch. Discussion ---------- Import Acme demo bundle from symfony standard edition See https://github.com/symfony/symfony-standard/issues/639 This allows to install the Acme demo bundle on project creation (default to false) Commits ------- 9e806a9 Import Acme demo bundle from symfony standard edition
fabpot
added a commit
to symfony/symfony-standard
that referenced
this pull request
Mar 30, 2014
…inneutron) This PR was merged into the 2.4-dev branch. Discussion ---------- Move Acme demo bundle to sensio DistributionBundle See https://github.com/symfony/symfony-standard/issues/639 Merge sensiolabs/SensioDistributionBundle#119 before this one Commits ------- eb5d496 Move Acme demo bundle to sensio DistributionBundle
Member
|
@romainneutron I've merged this but it was not finished as the routing for the Acme bundle is still in the Symfony SE repo, the same goes for the security. Can you submit a new PR to fix this? |
Member
|
Also, the question about installing the Acme demo bundle should only be asked the very first time the command is run, not everytime install is run. |
fabpot
added a commit
that referenced
this pull request
Apr 1, 2014
… (romainneutron) This PR was squashed before being merged into the 3.0.x-dev branch (closes #120). Discussion ---------- Add routing and security configuration to AcmeDemoBundle This follows #119 I'm not sur of the right implementation: I'm using the Yaml component that strips blank lines and comments. As the AcmeDemoBundle is supposed to be used by newcomers, I don't think that losing readability and comments in these config files is a good thing. Commits ------- a2ee3ad Add routing and security configuration to AcmeDemoBundle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/symfony/symfony-standard/issues/639
This allows to install the Acme demo bundle on project creation (default to false)