[MRG+1] removing deprecated files in metrics#5456
Merged
amueller merged 2 commits intoscikit-learn:masterfrom Oct 21, 2015
aabadie:remove_deprecation_metrics
Merged
[MRG+1] removing deprecated files in metrics#5456amueller merged 2 commits intoscikit-learn:masterfrom aabadie:remove_deprecation_metrics
amueller merged 2 commits intoscikit-learn:masterfrom
aabadie:remove_deprecation_metrics
Conversation
20 tasks
Contributor
Author
|
@ogrisel, this PR fixes the deprecation message in metrics.py |
Member
|
This was correct. It is part of #3442. If you |
Contributor
Author
|
@mueller, my understanding is that the message should be updated in 0.17.X branch (the corresponding commit will then be cherry-picked from master) and, still in master, remove the metrics.py file. Do you confirm ? |
added 2 commits
October 21, 2015 13:13
confirm deprecation starting from 0.16 and removal after 0.18
Member
|
It should be removed in master. I don't think anything needs to be updated in 0.17.X. |
Member
|
@GaelVaroquaux @ogrisel This can also be merged! |
Member
|
LGTM. +1 for merge from my side. |
amueller
added a commit
that referenced
this pull request
Oct 21, 2015
[MRG+1] removing deprecated files in metrics
Member
|
maybe should have squashed. well whatever. Thanks @aabadie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly fixed metrics deprecated code: removed metrics.py file
#5434