Skip to content

[MRG+1] MAINT split sklearn/metrics/metrics.py#3442

Merged
GaelVaroquaux merged 3 commits intoscikit-learn:masterfrom
arjoly:split-metrics-module
Jul 19, 2014
Merged

[MRG+1] MAINT split sklearn/metrics/metrics.py#3442
GaelVaroquaux merged 3 commits intoscikit-learn:masterfrom
arjoly:split-metrics-module

Conversation

@arjoly
Copy link
Copy Markdown
Member

@arjoly arjoly commented Jul 19, 2014

As the title said.

This is a bit brutal, but file are of more manageable size.
It intends to fix #3425

@GaelVaroquaux
Copy link
Copy Markdown
Member

👍 for merge. The new layout is good!

@arjoly arjoly changed the title MAINT split sklearn/metrics/metrics.py [MRG+1] MAINT split sklearn/metrics/metrics.py Jul 19, 2014
@arjoly
Copy link
Copy Markdown
Member Author

arjoly commented Jul 19, 2014

a last +1? (ping @amueller, @ogrisel, @vene)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get something a little bit more explanatory here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I forgot to change it in the refactoring.

@jnothman
Copy link
Copy Markdown
Member

Do we need to retain a deprecated sklearn.metrics.metrics for backwards compatibility?

@arjoly
Copy link
Copy Markdown
Member Author

arjoly commented Jul 19, 2014

@jnothman I have taken your remark into account.

@arjoly
Copy link
Copy Markdown
Member Author

arjoly commented Jul 19, 2014

Do we need to retain a deprecated sklearn.metrics.metrics for backwards compatibility?

Documentation references sklearn.metrics and not sklearn.metrics.metrics.

@GaelVaroquaux
Copy link
Copy Markdown
Member

I need to touch the metrics module to fix some failures on numpy 1.9b2. Could this PR get an additional 👍, so that I avoid conflicts?

@arjoly
Copy link
Copy Markdown
Member Author

arjoly commented Jul 19, 2014

@amueller I have added the friendly warning.

+1 irl from @amueller

@GaelVaroquaux
Copy link
Copy Markdown
Member

+1 irl from @amueller

Yey!

GaelVaroquaux added a commit that referenced this pull request Jul 19, 2014
[MRG+1] MAINT split sklearn/metrics/metrics.py
@GaelVaroquaux GaelVaroquaux merged commit fa26f64 into scikit-learn:master Jul 19, 2014
@arjoly arjoly deleted the split-metrics-module branch July 19, 2014 18:08
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) when pulling c91a4af on arjoly:split-metrics-module into 0807e19 on scikit-learn:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Splitting the metrics module in sub-module

4 participants