[MRG] Fixed warnings for DataDimensionalityWarning and decision function#5395
Merged
ogrisel merged 1 commit intoscikit-learn:masterfrom Oct 15, 2015
Merged
Conversation
Member
|
|
…ecision_function_shape.
a25aa88 to
31a5a5f
Compare
Member
Author
|
I did it for |
Member
|
It's good to silence such warnings so merging this PR. However for the future it would be better to explain which warning is silenced in tests and why in inline comments. |
ogrisel
added a commit
that referenced
this pull request
Oct 15, 2015
[MRG] Fixed warnings for DataDimensionalityWarning and decision function
Member
Author
|
You're right. Though I actually only silenced warnings in the LSHForest, where the reason probably is "the parameters are not appropriate for the test data" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation / rebase of #5277 with some fixes.
Closes some of #5089.
Thanks @hasancansaral