Skip to content

[issue #5089] Fixed warnings for DataDimensionalityWarning, decision_function and decision_function_shape.#5277

Closed
hasancansaral wants to merge 1 commit intoscikit-learn:masterfrom
hasancansaral:deprecation-warnings
Closed

[issue #5089] Fixed warnings for DataDimensionalityWarning, decision_function and decision_function_shape.#5277
hasancansaral wants to merge 1 commit intoscikit-learn:masterfrom
hasancansaral:deprecation-warnings

Conversation

@hasancansaral
Copy link
Copy Markdown

@hasancansaral hasancansaral commented Sep 16, 2015

@amueller [issue #5089] Fixed warnings for DataDimensionalityWarning, decision_function and decision_function_shape.

TomDLT
TomDLT reviewed Sep 16, 2015
View reviewed changes
sklearn/svm/tests/test_sparse.py Outdated
Copy link
Copy Markdown
Member

@TomDLT TomDLT Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the warning is silenced, but the test will fail in 0.18, when default decision_function_shape will change to 'ovr'.
I would rather add now decision_function_shape='ovo'.

@hasancansaral
Copy link
Copy Markdown
Author

hasancansaral commented Sep 16, 2015

@TomDLT Done.

TomDLT
TomDLT reviewed Sep 16, 2015
View reviewed changes
sklearn/svm/tests/test_sparse.py Outdated
Copy link
Copy Markdown
Member

@TomDLT TomDLT Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add a new line for pep8 compliance.

@hasancansaral
Copy link
Copy Markdown
Author

hasancansaral commented Sep 16, 2015

@TomDLT Done, thanks.

@TomDLT
Copy link
Copy Markdown
Member

TomDLT commented Sep 16, 2015

As for the DataDimensionalityWarnings, I have suppressed all of them except for one, which I get when I run nosetest -v sklearn/neighbors but not when nosetests -v sklearn/neighbors/tests. Could you help me with that? Thanks.

The remaining DataDimensionalityWarning is in this doctest.
I don't know if a ignore_warning is a good idea in a doctest.

@hasancansaral
Copy link
Copy Markdown
Author

hasancansaral commented Sep 16, 2015

@TomDLT Yes, I have found it. The issue said removing warnings from the test suit, so I didn't touch to doctests.

@TomDLT TomDLT mentioned this pull request Sep 16, 2015
Merged
@amueller amueller added this to the 0.17 milestone Sep 22, 2015
@amueller
Copy link
Copy Markdown
Member

amueller commented Sep 24, 2015

You could change the parameters or the data so that there is no warning?

@TomDLT TomDLT mentioned this pull request Sep 29, 2015
Closed
@vighneshbirodkar
Copy link
Copy Markdown
Contributor

vighneshbirodkar commented Sep 29, 2015

@hasancansaral I am working on the #5297, if you are busy and don't mind, can I use some of your changes ? I am working on the decision_function and some other warnings as well.

@amueller amueller mentioned this pull request Oct 13, 2015
Merged
@amueller
Copy link
Copy Markdown
Member

amueller commented Oct 15, 2015

merged via #5395

@amueller amueller closed this Oct 15, 2015
@hasancansaral hasancansaral deleted the deprecation-warnings branch January 16, 2016 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.17

Development

Successfully merging this pull request may close these issues.

4 participants

@hasancansaral @TomDLT @amueller @vighneshbirodkar