Seems straightforward. LGTM

Please rebase, but otherwise LGTM.

@jnothman done!

(Slightly unrelated) There seems to have been a change in the grid_search module... Is there a way for me to automatically track all such changes and incorporate into model_selection as and when they come? (w.r.t. #4294 )

I started "watching" scikit-learn and will check for any such changes to g_s, c_v or l_c modules that gets merged as often as I can and incorporate those into model_selection too... but am a little paranoid about missing a few changes...

Sorry for the stupid question! Simply checking the history of the file would suffice! :)

I don't know of a way to track changes to a file as such, but the following
should help:

git log model_selection..master sklearn/grid_search.py sklearn/pipeline.py
sklearn/learning_curve.py

(make sure you pull first!)

On 8 June 2015 at 21:12, Raghav R V notifications@github.com wrote:

@jnothman https://github.com/jnothman done!

(Slightly unrelated) There seems to have been a change in the grid_search
module... Is there a way for me to automatically track all such changes and
incorporate into model_selection as and when they come? (w.r.t. #4294
#4294 )

—
Reply to this email directly or view it on GitHub
#4829 (comment)
.

Thanks :)

If you'd rather a daily report, you could stick

git log master@{yesterday}..master sklearn/grid_search.py
sklearn/pipeline.py sklearn/learning_curve.py

in a cron job (and if properly set up it'll email any output to you)!

On 8 June 2015 at 21:28, Raghav R V notifications@github.com wrote:

Sorry for the stupid question! Simply checking the history of the file
would suffice! :)

—
Reply to this email directly or view it on GitHub
#4829 (comment)
.

see also https://git-scm.com/book/en/v2/Git-Tools-Revision-Selection

On 8 June 2015 at 21:32, Raghav R V notifications@github.com wrote:

Thanks :)

—
Reply to this email directly or view it on GitHub
#4829 (comment)
.

+1 for merge when rebased.

@jnothman This @yesterday is quite cool! I'll set up a cron job to send me a mail! Thanks a lot! ;)

@agramfort Have rebased :)

thanks @rvraghav93

Thanks for the reviews :)

I actually think checking the list of changes immediately before a rebase, using git log model_selection..master sklearn/grid_search.py sklearn/pipeline.py sklearn/learning_curve.py is probably more appropriate -- as long as you remember to do it before a rebase!

yes! I saved the above as an alias chkms! Thanks :)

[

sorry, I wrote pipeline instead of cross_validation above.

Also you can search for commits whose diffs introduce or remove an instance
of a word, e.g. git log b..master -S cross_validation. Or regex in diffs:
git log b..master -G '\b(cross_validation|grid_search)\b'

]

On 9 June 2015 at 08:11, Raghav R V notifications@github.com wrote:

yes! I saved the above as an alias chkms! Thanks :)

—
Reply to this email directly or view it on GitHub
#4829 (comment)
.