[MRG] remove deprecated stuff from 0.17#4370
Merged
ogrisel merged 2 commits intoscikit-learn:masterfrom Mar 18, 2015
Merged
Conversation
ca6ab01 to
ed1f093
Compare
Member
Author
|
I tried to remove the multi-label support from the multi-label generator, but even that was non-trivial. @arjoly your help would be much appreciated, maybe in a different pr? |
012efe7 to
fcfe3c5
Compare
Member
|
Haven't we disabled coveralls bot already?? @coveralls shoo go away! ;) |
24 tasks
fcfe3c5 to
e1af92b
Compare
Member
|
Great cleanup, merging. Indeed the remaining non-trivial stuff should better be addressed in separate PRs. |
ogrisel
added a commit
that referenced
this pull request
Mar 18, 2015
[MRG] remove deprecated stuff from 0.17
Member
|
BTW @amueller this kind of commits could be prefixed with a |
Member
|
-23k loc! 🍻 |
Member
Author
|
yep, should have been MAINT. |
Member
Author
|
The locs are mostly generated C for hmm ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes most of the deprecated things for 0.17.
Two items are left afterwards:
I'm not sure if we want cross_val_score and GridSearchCV to support iterators that support boolean masks. I think the intention was to remove this support completely, but I'm not sure. For now, I only removed the option to return boolean masks from the cross-validation iterators.