Skip to content

MNT Update environment and lockfile for build doc with matplotlib unpinned#29548

Merged
lesteve merged 1 commit intoscikit-learn:mainfrom
StefanieSenger:unpin_matplotlib
Jul 23, 2024
Merged

MNT Update environment and lockfile for build doc with matplotlib unpinned#29548
lesteve merged 1 commit intoscikit-learn:mainfrom
StefanieSenger:unpin_matplotlib

Conversation

@StefanieSenger
Copy link
Copy Markdown
Member

@StefanieSenger StefanieSenger commented Jul 23, 2024

Reference Issues/PRs

closes #29434

What does this implement/fix? Explain your changes.

This PR finishes the unpinning of matplotlib<3.9 in the doc build of Circle CI.

The updating of the examples had been done in #29471, which is merged.

Thanks for your support, @lesteve :)

@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 74efda0. Link to the linter CI: here

@StefanieSenger StefanieSenger changed the title MNT [doc build] build doc lockfiles with matplotlib unpinned MNT Update environments and build doc lockfiles with matplotlib unpinned Jul 23, 2024
@StefanieSenger StefanieSenger changed the title MNT Update environments and build doc lockfiles with matplotlib unpinned MNT Update environment and lockfile for build doc with matplotlib unpinned Jul 23, 2024
Copy link
Copy Markdown
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

The diff looks fine and we will see what the full doc build CI has to say about it but it seems promising

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Jul 23, 2024

The full doc build was succesful, so let's merge this one, thanks!

@lesteve lesteve merged commit d20e0b9 into scikit-learn:main Jul 23, 2024
@StefanieSenger StefanieSenger deleted the unpin_matplotlib branch July 23, 2024 14:32
MarcBresson pushed a commit to MarcBresson/scikit-learn that referenced this pull request Sep 2, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Unpin matplotlib<3.9 in doc build

2 participants