Skip to content

EXA Use tick_labels in boxplot for matplotlib>=3.9#29471

Merged
lesteve merged 4 commits intoscikit-learn:mainfrom
nithish08:nb/unpin-matplotlib
Jul 15, 2024
Merged

EXA Use tick_labels in boxplot for matplotlib>=3.9#29471
lesteve merged 4 commits intoscikit-learn:mainfrom
nithish08:nb/unpin-matplotlib

Conversation

@nithish08
Copy link
Copy Markdown
Contributor

@nithish08 nithish08 commented Jul 11, 2024 •
edited by lesteve
Loading

Make the examples run without DeprecationWarning for matplotlib>=3.9, see #29434.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 11, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 73b3ada. Link to the linter CI: here

@nithish08 nithish08 mentioned this pull request Jul 11, 2024
Closed
3 tasks
lesteve
lesteve reviewed Jul 12, 2024
View reviewed changes
@lesteve lesteve changed the title CI handle labels for matplotlib>=3.9 EXA handle labels for matplotlib>=3.9 Jul 15, 2024
@lesteve lesteve changed the title EXA handle labels for matplotlib>=3.9 EXA Use tick_labels in boxplot for matplotlib>=3.9 Jul 15, 2024
@lesteve
Copy link
Copy Markdown
Member

lesteve commented Jul 15, 2024 •
edited
Loading

Thanks, I have pushed a tweak for the comment. I have enabled auto-merge, so this PR will be merged when CI is green.

Side-comment: you don't really need to merge main into your branch. The main reason you would need to do this only if there are conflicts, i.e. you changed some lines that have been changed in main since you created your branch. In other cases, a maintainer will ask you explicitly to merge main into your branch if there is a need.

@lesteve lesteve enabled auto-merge (squash) July 15, 2024 05:05
@lesteve lesteve merged commit 13a1791 into scikit-learn:main Jul 15, 2024
@nithish08 nithish08 deleted the nb/unpin-matplotlib branch July 15, 2024 15:01
@StefanieSenger StefanieSenger mentioned this pull request Jul 23, 2024
Merged
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024
@nithish08 @lesteve @glemaitre
EXA Use tick_labels in boxplot for matplotlib>=3.9 (scikit-learn#29471)
d11dcde 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre pushed a commit that referenced this pull request Sep 11, 2024
@nithish08 @lesteve @glemaitre
EXA Use tick_labels in boxplot for matplotlib>=3.9 (#29471)
436cb76 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lesteve lesteve lesteve approved these changes

Assignees

No one assigned

Labels

Build / CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nithish08 @lesteve