CI Fix following scipy dev coo_matrix attr renaming#28374
Merged
lesteve merged 2 commits intoscikit-learn:mainfrom Feb 7, 2024
Merged
CI Fix following scipy dev coo_matrix attr renaming#28374lesteve merged 2 commits intoscikit-learn:mainfrom
lesteve merged 2 commits intoscikit-learn:mainfrom
Conversation
adrinjalali
approved these changes
Feb 6, 2024
Member
adrinjalali
left a comment
There was a problem hiding this comment.
lgtm when CI is green (codecov)
Member
Author
|
I restarted the build with codecov failing and CI is green. Merging my own PR with 1 approval. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 13, 2024
glemaitre
pushed a commit
that referenced
this pull request
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in #28372. Closes #28357.
The
.indices->.coordsattr renaming was done in scipy/scipy#20003.