MAINT: sparse: change coo_matrix.indices to coo_matrix.coords#20003
Merged
perimosocordiae merged 2 commits intoscipy:mainfrom Feb 5, 2024
Merged
MAINT: sparse: change coo_matrix.indices to coo_matrix.coords#20003perimosocordiae merged 2 commits intoscipy:mainfrom
perimosocordiae merged 2 commits intoscipy:mainfrom
Conversation
perimosocordiae
requested changes
Feb 2, 2024
Member
perimosocordiae
left a comment
There was a problem hiding this comment.
Looks good, except for a few documentation issues where we want to use the full word instead of referring to the variable name.
Contributor
Author
|
Good catch -- I didn't think enough about docs and comments. But I suspect that its better that you make those calls anyway. I've made those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid confusion between formats, the recently implemented attribute name
indicesfor COO format is changed in this PR tocoords.This is a public attribute, but did not exist in 1.12, so merging this before 1.13 will not have any backward compatibility issues.
The CSR/CSC formats already use the attribute name
indices. So while the wordindicesis fine for COO, it may cause confusion between compressed and COO especially when working with both, converting etc. The namecoordsis arguably better anyway because it matches the "COO" of the COO format name. Both words seem to mean the same thing in English.