MNT Work-around sphinx-gallery UnicodeDecodeError in recommender system#27969
Merged
lesteve merged 1 commit intoscikit-learn:mainfrom Dec 18, 2023
Merged
MNT Work-around sphinx-gallery UnicodeDecodeError in recommender system#27969lesteve merged 1 commit intoscikit-learn:mainfrom
UnicodeDecodeError in recommender system#27969lesteve merged 1 commit intoscikit-learn:mainfrom
Conversation
Member
|
Can you open an issue in sphinx-gallery about this, or even a PR, basically the fix should be to specify the encoding i.e. something like I am fine with this work-around in the mean time. |
lesteve
approved these changes
Dec 18, 2023
UnicodeDecodeError of recommender for certain codec when doc buildUnicodeDecodeError in recommender system
Contributor
Author
|
Sure, I have opened sphinx-gallery/sphinx-gallery#1244 for this. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
NA.
What does this implement/fix? Explain your changes.
When running doc build, some characters in
examples/causeUnicodeDecodeErrorfor certain codec (e.g.gbkfor my machine). The root cause is the following lines in thesphinx-gallerypackage which does not specify the encoding.https://github.com/sphinx-gallery/sphinx-gallery/blob/a34b72cdcd52cc905761ea80282916af6638ec38/sphinx_gallery/recommender.py#L193-L195
This PR changes
–to-and“”to""to avoid these errors.