Skip to content

BUG: UnicodeDecodeError in recommender#1244

Merged
larsoner merged 1 commit intosphinx-gallery:masterfrom
Charlie-XIAO:recommender-encoding
Dec 18, 2023
Merged

BUG: UnicodeDecodeError in recommender#1244
larsoner merged 1 commit intosphinx-gallery:masterfrom
Charlie-XIAO:recommender-encoding

Conversation

@Charlie-XIAO
Copy link
Copy Markdown
Contributor

See also scikit-learn/scikit-learn#27969. Without specifying the encoding such as utf-8, some systems would use other codecs (e.g. gbk) which cannot decode some characters (e.g. , , ). This PR specifies encoding="utf-8".

@larsoner larsoner added the bug label Dec 18, 2023
@larsoner
Copy link
Copy Markdown
Contributor

Thanks @Charlie-XIAO !

@larsoner larsoner enabled auto-merge (squash) December 18, 2023 14:11
@larsoner larsoner merged commit 9609699 into sphinx-gallery:master Dec 18, 2023
@Charlie-XIAO Charlie-XIAO deleted the recommender-encoding branch December 18, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants