Merged
Conversation
betatim
approved these changes
Aug 18, 2023
Member
betatim
left a comment
There was a problem hiding this comment.
LGTM.
I can't decide if this should be type() == or if this should be using isinstance. Given that this code hasn't been changed for ~four years (or even longer) I think using the noqa is fine. Maybe something to condsider for the future is if we can make linting less pedantic for tests (maybe we allow some "weird" constructs in our tests that in the library wouldn't be allowed.)
Member
|
I am also think that we should pin the version of ruff in the near future ;) |
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
elindgren
pushed a commit
to elindgren/scikit-learn
that referenced
this pull request
Oct 5, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems very similar to #27039, probably due to the release of ruff yesterday. This is breaking everyone PRs.
Maybe another argument for pinning
ruff?