MNT fix ruff type vs isinstance errors#27039
Merged
lesteve merged 1 commit intoscikit-learn:mainfrom Aug 9, 2023
Merged
Conversation
betatim
approved these changes
Aug 9, 2023
Member
betatim
left a comment
There was a problem hiding this comment.
LGTM.
I'd expect a comment in the code if the author (for some obscure reason) really wanted to check the type instead of the usual/normal isinstance.
lesteve
approved these changes
Aug 9, 2023
Member
Author
|
@lesteve we can pin the version, but regarding the lock files, I've had difficulties dealing with them, they're large, and it's very confusing to manage them. So for now I rather stay out of it personally 😁 |
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues raised by new ruff. Right now linting is failing on
main