MNT Use assert_no_warnings from numpy.testing#27031
Merged
thomasjpfan merged 2 commits intoscikit-learn:mainfrom Aug 9, 2023
Merged
MNT Use assert_no_warnings from numpy.testing#27031thomasjpfan merged 2 commits intoscikit-learn:mainfrom
thomasjpfan merged 2 commits intoscikit-learn:mainfrom
Conversation
OmarManzoor
approved these changes
Aug 8, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @thomasjpfan
betatim
approved these changes
Aug 8, 2023
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Saw this reviewing #27013
What does this implement/fix? Explain your changes.
As noted by the comment, we can use
assert_no_warningsdirectly from NumPy given our minimum support version is1.17.3.Any other comments?
We can rewrite the tests, turning warnings into errors, but I think a PR removing code is already a benefit.