ENH: Update numpy exceptions imports#27013
Merged
betatim merged 3 commits intoscikit-learn:mainfrom Aug 8, 2023
Merged
Conversation
785d4f8 to
d44672a
Compare
thomasjpfan
reviewed
Aug 7, 2023
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR! I think the following lines can be updated to catch VisibleDeprecationWarning moving forward:
The np.VisibleDeprecationWarning can be replaced with:
-Werror::sklearn.utils.fixes.VisibleDeprecationWarning
b9c4c60 to
2447534
Compare
Contributor
Author
|
@thomasjpfan Sure! I updated the Azure CI script. |
rgommers
approved these changes
Aug 7, 2023
Contributor
rgommers
left a comment
There was a problem hiding this comment.
LGTM too. I'm merging the upstream PR with the removals now, so I'd suggest to get this in to avoid failures when the next numpy nightly is uploaded.
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Connected to numpy/numpy#24316.
What does this implement/fix? Explain your changes.
Due to NumPy's main namespace being changed in numpy/numpy#24316, here I update warning imports.