FIX Disable set_output for label encoder#26940
Merged
adrinjalali merged 3 commits intoscikit-learn:mainfrom Jul 31, 2023
Merged
FIX Disable set_output for label encoder#26940adrinjalali merged 3 commits intoscikit-learn:mainfrom
adrinjalali merged 3 commits intoscikit-learn:mainfrom
Conversation
adrinjalali
approved these changes
Jul 30, 2023
OmarManzoor
approved these changes
Jul 31, 2023
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #26854
What does this implement/fix? Explain your changes.
This PR uses
auto_wrap_output_keys=Noneto fully disableset_outputfor the label encoders and any wrapping. The set output API was not designed to transformy.Any other comments?
Even with this PR, Sphinx still picks up
set_outputand adds it as a method in the API docs. Given that this PR fixes the functionality, I think we can merge and follow up with the documentation fix.