Skip to content

DOC: a simple implementation of folding#26625

Merged
glemaitre merged 5 commits intoscikit-learn:mainfrom
GaelVaroquaux:details_doc
Jun 21, 2023
Merged

DOC: a simple implementation of folding#26625
glemaitre merged 5 commits intoscikit-learn:mainfrom
GaelVaroquaux:details_doc

Conversation

@GaelVaroquaux
Copy link
Copy Markdown
Member

An alternative to #26619

Implement html folding via "raw-html" directives.

This is just a first iteration of the idea to demonstrate the feasibility.

The benefit that I see is that it does not collide with other sphinx directives (unlike the dropdown code explored in #26619 )

cc @ArturoAmorQ @Tech-Netiums

Todo:

  • If people are good with CSS, it could be improved. I just did a first iteration.
  • Document this

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 19, 2023

Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

@GaelVaroquaux
Copy link
Copy Markdown
Member Author

@glemaitre : I have implemented tooltips, as you asked for

@GaelVaroquaux
Copy link
Copy Markdown
Member Author

@glemaitre : can I haz review? Merge?

Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will really like the addition of the hover.

@glemaitre glemaitre merged commit 23ff51c into scikit-learn:main Jun 21, 2023
@glemaitre
Copy link
Copy Markdown
Member

Merging this part. @ArturoAmorQ you can go back to the documentation. I will review it after the sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants