DOC Add dropdowns to Module 2.3 Clustering#26619
DOC Add dropdowns to Module 2.3 Clustering#26619Charlie-XIAO merged 32 commits intoscikit-learn:mainfrom
Conversation
GaelVaroquaux
left a comment
There was a problem hiding this comment.
I find that folding very small topics in counter-productive: it decreases crowding very little and adds
I would prefer if we undid the changes for all the small blocks and kept them only for the large one
|
I've just noticed: this PR breaks the width of the docs: This PR |
greyisbetter
left a comment
There was a problem hiding this comment.
So not just 5th but you're also hiding 4th level like Algorithm description or Mathematical details?
I am working on better guidelines for the use of dropdowns on #26636. For the moment the proposal is to use them to hide:
Low level sections such as I will edit the Issue accordingly. |
Charlie-XIAO
left a comment
There was a problem hiding this comment.
Here are a couple of comments, otherwise LGTM, thanks!
There was a problem hiding this comment.
I checked the artifacts and the rendering looks nice. Thanks @ArturoAmorQ!
Should we merge or we still need more reviews?
@Charlie-XIAO For the dropdown PRs we typically require just one approve, so feel free to merge :) |
Reference Issues/PRs
Requires #26625. First steps towards #26617.
What does this implement/fix? Explain your changes.
This PR introduces dropdowns to the Module 2.3 Clustering. Dropdowns can help users avoid scrolling and can quickly get them access to a given content, especially trough large pages such as the mentioned above.
Any other comments?