Skip to content

TST skip test_dataframe_support if matplotlib not installed#23322

Merged
ogrisel merged 1 commit intoscikit-learn:mainfrom
jeremiedbb:fix-tst-decision-boundary-matplotlib
May 10, 2022
Merged

TST skip test_dataframe_support if matplotlib not installed#23322
ogrisel merged 1 commit intoscikit-learn:mainfrom
jeremiedbb:fix-tst-decision-boundary-matplotlib

Conversation

@jeremiedbb
Copy link
Copy Markdown
Member

follow up of #23318

The test should be skipped if matplotlib is not installed. It's not catched by the CI because it's always installed when pandas is but it was catched in #23321

@jeremiedbb jeremiedbb added To backport PR merged in master that need a backport to a release branch defined based on the milestone. No Changelog Needed Quick Review For PRs that are quick to review labels May 10, 2022
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogrisel ogrisel merged commit 07c1a58 into scikit-learn:main May 10, 2022
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:inspection No Changelog Needed Quick Review For PRs that are quick to review To backport PR merged in master that need a backport to a release branch defined based on the milestone.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants