Skip to content

FIX DecisionBoundaryPlot should not raise spurious warning#23318

Merged
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
glemaitre:is/23311
May 10, 2022
Merged

FIX DecisionBoundaryPlot should not raise spurious warning#23318
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
glemaitre:is/23311

Conversation

@glemaitre
Copy link
Copy Markdown
Member

closes #23311

Recreate a dataframe on the fly in DecisionBoundaryPlot to avoid predicting on a NumPy array while the classifier have been fitted on a dataframe.

@glemaitre glemaitre added this to the 1.1 milestone May 10, 2022
@glemaitre glemaitre added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label May 10, 2022
Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI is green.

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glemaitre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:inspection No Changelog Needed To backport PR merged in master that need a backport to a release branch defined based on the milestone.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious warning with DecisionBoundaryPlot

3 participants